Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add accessibility-checker for additional tests #2652

Merged
merged 17 commits into from
Jul 16, 2024
Merged

test: add accessibility-checker for additional tests #2652

merged 17 commits into from
Jul 16, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented May 16, 2024

Proposed changes

closes #2579

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions github-actions bot added 🚢📀cicd Changes inside .github folder 📺showcases Changes to 1-n showcases labels May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/test-accessibility-checker

@nmerget nmerget enabled auto-merge (squash) May 16, 2024 14:44
@github-actions github-actions bot added the 🏘components Changes inside components folder label May 17, 2024
@mfranzke
Copy link
Member

@nmerget there's a package lock conflict

@nmerget nmerget requested a review from bruno-sch as a code owner June 27, 2024 07:25
@mfranzke mfranzke added the 👂accessibility Accessibility issues/improvements label Jul 15, 2024
@mfranzke mfranzke mentioned this pull request Jul 16, 2024
Open
@nmerget nmerget merged commit 6270669 into main Jul 16, 2024
55 checks passed
@nmerget nmerget deleted the test-accessibility-checker branch July 16, 2024 04:36
@mfranzke mfranzke self-assigned this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees

@mfranzke mfranzke

Labels
👂accessibility Accessibility issues/improvements 🚢📀cicd Changes inside .github folder 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test other accessibility tools for local development and/or CICD
3 participants
@nmerget @mfranzke @bruno-sch